Google changed their formula. module should now deal with:
google_ad_client = "pub-xxxxxxxx";
google_ad_slot = "02353245";
google_ad_width = 468;
google_ad_height = 15;
While we are playing here, the module should be re-organized and default should be a public service advertisement
Current Adsense module is too complicated to set-up as we can read here:
http://tikiwiki.org/Module+Adsense
There are way too many forum posts for something which should be really simple to set up:
http://tikiwiki.org/tiki-searchindex.php?highlight=adsense&where=forums
So, I suggest:
The public service advertisement should appear instead of the current "You forgot your Google ad_client number !" message. So people would know right away that the connection with Google is OK.
By default, it should be a fairly small ad so it fits nicely in a module.
And if the user is admin level (check for tiki_p_admin), then, add a link to documentation on how to set pub-xxxxxxxxxxxx and others...
http://doc.tikiwiki.org/tiki-index.php?page=Module+adsense
So, if no pub-xxx number is set, use pub-xxxxxxxxxxxx (which provides the public service advertisement) with a warning for admins.
If the admin specifically wants a public service advertisement, he can set the pub number as pub-xxxxxxxxxxxx. In which case, there should not be a warning to admins on how to set.
Finally, if the pub number is set normally (ex.: pub-1234...), no admin warning should appear.